Changeset 1770

Timestamp:

2/8/2010 7:41:24 AM (2 years ago)

Author:

lowjoel

Message:

Marked disposable classes' Dispose(bool) member protected virtual; or private and sealed the class if the class is not meant to be inherited. Addresses #275: Code Review

Location:

branches/eraser6/CodeReview

Files:

• Eraser.Util/ConsoleWindow.cs (modified) (1 diff)
• Eraser.Util/Security.cs (modified) (1 diff)
• Eraser.Util/VolumeInfo.cs (modified) (2 diffs)
• Eraser/Program.ConsoleProgram.cs (modified) (1 diff)
• Eraser/Settings.cs (modified) (1 diff)

branches/eraser6/CodeReview/Eraser.Util/ConsoleWindow.cs

@@ -30 +30 @@
     /// object.
     /// </summary>
-    public class ConsoleWindow : IDisposable
+    public sealed class ConsoleWindow : IDisposable
     {
         public ConsoleWindow()

branches/eraser6/CodeReview/Eraser.Util/Security.cs

@@ -146 +146 @@
         }
 
-        public void Dispose(bool disposing)
+        private void Dispose(bool disposing)
         {
             if (disposing)

branches/eraser6/CodeReview/Eraser.Util/VolumeInfo.cs

@@ -716 +716 @@
     }
 
-    public class VolumeLock : IDisposable
+    public sealed class VolumeLock : IDisposable
     {
         internal VolumeLock(FileStream stream)
@@ -745 +745 @@
 
         [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "disposing")]
-        void Dispose(bool disposing)
+        private void Dispose(bool disposing)
         {
             //Flush the contents of the buffer to disk since after we unlock the volume

branches/eraser6/CodeReview/Eraser/Program.ConsoleProgram.cs

@@ -72 +72 @@
             }
 
-            public void Dispose(bool disposing)
+            protected virtual void Dispose(bool disposing)
             {
                 //Flush the buffered output to the console

branches/eraser6/CodeReview/Eraser/Settings.cs

@@ -40 +40 @@
         /// Registry-based storage backing for the Settings class.
         /// </summary>
-        private class RegistrySettings : Manager.Settings, IDisposable
+        private sealed class RegistrySettings : Manager.Settings, IDisposable
         {
             /// <summary>