Changeset 1626

Timestamp:

1/21/2010 2:59:08 AM (2 years ago)

Author:

lowjoel

Message:

Removed unnecessary using declarations and fixed a sharing violation with the PostDataBuilder? class (due to an undisposed stream which I used when getting the Boundary property.) Addresses #307: Eraser Updater restructuring and addresses #308: Upgrade BlackBox? to use the ProgressManager? classes

Location:

branches/eraser6/CodeReview

Files:

• Eraser.Util/PostDataBuilder.cs (modified) (1 diff)
• Eraser/BlackBoxUploadForm.cs (modified) (1 diff)

branches/eraser6/CodeReview/Eraser.Util/PostDataBuilder.cs

@@ -122 +122 @@
             set
             {
-                if (Stream.Length != 0)
-                    throw new InvalidOperationException("The boundary cannot be set as data " +
-                        "already exists in the buffer.");
+                using (Stream stream = Stream)
+                    if (stream.Length != 0)
+                        throw new InvalidOperationException("The boundary cannot be set as data " +
+                            "already exists in the buffer.");
                 boundary = value;
             }

branches/eraser6/CodeReview/Eraser/BlackBoxUploadForm.cs

@@ -32 +32 @@
 
 using ProgressChangedEventArgs = System.ComponentModel.ProgressChangedEventArgs;
-using ProgressChangedEventHandler = System.ComponentModel.ProgressChangedEventHandler;
 using EraserProgressChangedEventArgs = Eraser.Util.ProgressChangedEventArgs;
-using EraserProgressChangedEventHandler = Eraser.Util.ProgressChangedEventHandler;
 
 namespace Eraser